Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APICallMixin url_args handling #6468

Merged
merged 1 commit into from Feb 11, 2024

Conversation

30350n
Copy link
Contributor

@30350n 30350n commented Feb 11, 2024

The current implementation of APICallMixin.api_call handles url_args very weirdly. This improves the behavior, so that non single character string args will be handled correctly.

Before:

>>> api_build_url_args({'a': 'abc123'})
'?a=a,b,c,1,2,3'

After:

>>> api_build_url_args({'a': 'abc123'})
'?a=abc123'

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit a38c501
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65c928113f94400008fd726e

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed plugin Plugin ecosystem labels Feb 11, 2024
@SchrodingersGat SchrodingersGat merged commit b372db8 into inventree:master Feb 11, 2024
27 checks passed
@SchrodingersGat
Copy link
Member

Nice catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed plugin Plugin ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants