-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move media operations to storages backend #6478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matmair/issue2585
matmair
added
setup
Relates to the InvenTree setup / installation process
refactor
labels
Feb 13, 2024
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matmair
changed the title
Move media operations to storages backend
WIP: Move media operations to storages backend
Feb 13, 2024
Currently a non-functional WIP |
…matmair/issue2585
SchrodingersGat
approved these changes
Feb 14, 2024
…matmair/issue2585
matmair
changed the title
WIP: Move media operations to storages backend
Move media operations to storages backend
Mar 21, 2024
@SchrodingersGat ready for review; next PR in this series is the new Files model |
@matmair LGTM but let's keep a close eye on this over the next few weeks before pushing next stable. |
There are another few changes incoming to close out #5703 so there will be a few other huge changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #5703. Changes all media (label, attachments, reports) to use Django's storage API.
The following files are not covered: config.yaml, plugins.txt, secret.txt, locale_stats.json as they are used in management commands / during startup and possible solutions felt unintuitive/made config stuff much more complicated.
This allows the usage of alternative storage backends like S3. This PR does not include the dependencies, config, docs, etc. for that. This PR is an internal refactor in preparation for the new File model.
Part of adressing #2585.