Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move media operations to storages backend #6478

Merged
merged 31 commits into from
Mar 24, 2024

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Feb 13, 2024

This PR is part of #5703. Changes all media (label, attachments, reports) to use Django's storage API.
The following files are not covered: config.yaml, plugins.txt, secret.txt, locale_stats.json as they are used in management commands / during startup and possible solutions felt unintuitive/made config stuff much more complicated.

This allows the usage of alternative storage backends like S3. This PR does not include the dependencies, config, docs, etc. for that. This PR is an internal refactor in preparation for the new File model.

Part of adressing #2585.

@matmair matmair added setup Relates to the InvenTree setup / installation process refactor labels Feb 13, 2024
@matmair matmair added this to the 0.15.0 milestone Feb 13, 2024
@matmair matmair self-assigned this Feb 13, 2024
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit e1f65c2
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65fe11f2fcad2700082df1d4
😎 Deploy Preview https://deploy-preview-6478--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair matmair changed the title Move media operations to storages backend WIP: Move media operations to storages backend Feb 13, 2024
@matmair
Copy link
Contributor Author

matmair commented Feb 13, 2024

Currently a non-functional WIP

@matmair matmair changed the title WIP: Move media operations to storages backend Move media operations to storages backend Mar 21, 2024
@matmair matmair marked this pull request as ready for review March 22, 2024 23:12
@matmair
Copy link
Contributor Author

matmair commented Mar 22, 2024

@SchrodingersGat ready for review; next PR in this series is the new Files model

@SchrodingersGat
Copy link
Member

@matmair LGTM but let's keep a close eye on this over the next few weeks before pushing next stable.

@SchrodingersGat SchrodingersGat merged commit cfe00aa into inventree:master Mar 24, 2024
22 checks passed
@matmair matmair deleted the matmair/issue2585 branch March 24, 2024 14:44
@matmair
Copy link
Contributor Author

matmair commented Mar 24, 2024

There are another few changes incoming to close out #5703 so there will be a few other huge changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants