New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pdf2image kwargs #6488
Added pdf2image kwargs #6488
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
I would suggest that we add a specific optional argument such as |
I now added the direct |
I agree, I am happy with the implementation as it stands |
While investigating some print quality issues, I noticed that there are some issues with the rendered png. So I first looked into to intermediately generated pdf, but everything looks fine there. So I suspect this has something todo with the png rendering. After a lot of playing with different options I found out that the pdf2image library has an optional setting (
use_pdftocairo=True
) to usepdftocairo
instead ofpdftoppm
which is used by default.So this PR adds an option to let the developer specify some custom options to pass over to
pdf2image.convert_from_bytes(...)
. Not sure if we should use Cairo by default, as this may can break some printing plugins?