[PUI] Make API form Select Field theme-aware #6521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Does this close #5836? |
|
Seems to be the case |
|
Yes :> |
matmair
added
bug
|
@LavissaWoW could you also take a look at #5824? |
|
@matmair Can do! |
LavissaWoW
changed the title
|
Cheers @LavissaWoW , LGTM |
wolflu05
reviewed
Feb 20, 2024
| // Field doesn't follow Mantine theming | ||
| // Define color theme to pass to field based on Mantine theme | ||
| const th = useMantineTheme(); | ||
| let colors: any; |
There was a problem hiding this comment.
Same thing here, it would make sense to wrap this into a useMemo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding theme awareness to
react-selectfield in forms.Closes #5836