[PUI] Make Category tree theme-aware #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matmair
added
bug
LavissaWoW
changed the title
|
Great work @LavissaWoW :) |
wolflu05
reviewed
Feb 20, 2024
| ? mantineTheme.colorScheme | ||
| : mantineTheme.primaryColor; | ||
|
|
||
| const themes: ThemeSettings = { |
There was a problem hiding this comment.
It would make sense to wrap this into a useMemo for performance reasons.
There was a problem hiding this comment.
What would the dependency be then? Output of useMantineTheme()?
There was a problem hiding this comment.
Yes, every variable that is used inside the useMemo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5824