Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate CUI url paths and tests #6543

Merged
merged 13 commits into from Feb 22, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Feb 21, 2024

This PR creates a clearer separation between CUI and PUI URLs, enabling users to fully disable CUI content serving. It also tags CUI test to make it possible to disable running them temporarily.

@matmair matmair added CI CI / unit testing ecosystem refactor labels Feb 21, 2024
@matmair matmair self-assigned this Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 27c949f
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65d7cce500c34800085001bf

@matmair matmair changed the title WIP: Seperate CUI paths and tests Seperate CUI url paths and tests Feb 22, 2024
@matmair matmair marked this pull request as ready for review February 22, 2024 01:10
@matmair matmair marked this pull request as draft February 22, 2024 01:11
@matmair matmair marked this pull request as ready for review February 22, 2024 12:09
@matmair matmair added this to the 0.14.0 milestone Feb 22, 2024
@matmair matmair added the Platform UI Related to the React based User Interface label Feb 22, 2024
@matmair matmair mentioned this pull request Feb 22, 2024
Copy link
Member

@SchrodingersGat SchrodingersGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty reasonable, a bit of code to prune back out later on but should be OK

InvenTree/order/test_views.py Outdated Show resolved Hide resolved
InvenTree/stock/models.py Outdated Show resolved Hide resolved
Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
@matmair
Copy link
Member Author

matmair commented Feb 22, 2024

@SchrodingersGat I hope to just remove most code that is tagged at that point ;-)

@SchrodingersGat
Copy link
Member

Sounds good. Happy to merge this when it passes?

@matmair
Copy link
Member Author

matmair commented Feb 22, 2024

Yes please @SchrodingersGat

@SchrodingersGat SchrodingersGat enabled auto-merge (squash) February 22, 2024 22:53
@SchrodingersGat SchrodingersGat merged commit 6f0b2b3 into inventree:master Feb 22, 2024
21 checks passed
@matmair matmair deleted the pui-seperate-cui-logic branch February 23, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem Platform UI Related to the React based User Interface refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants