Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: push both multiple image tags #6614

Merged
merged 2 commits into from Mar 2, 2024

Conversation

SchrodingersGat
Copy link
Member

Fix for currently broken docker tags

Ref: #6562 (comment)

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed CI CI / unit testing ecosystem docker Docker / docker-compose labels Mar 1, 2024
@SchrodingersGat SchrodingersGat added this to the 0.14.0 milestone Mar 1, 2024
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 5f3e365
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65e25ca26ffe8d000834070a

Copy link
Contributor

@wolflu05 wolflu05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you now need to disable one of the matrix entries so that the docker image is only built and uploaded once.

@SchrodingersGat
Copy link
Member Author

I think you now need to disable one of the matrix entries so that the docker image is only built and uploaded once.

Yes, the matrix strategy does not seem appropriate here. Waiting for @matmair to comment on this

@wolflu05
Copy link
Contributor

wolflu05 commented Mar 1, 2024

I think at the end the matrix strategy is not a bad choice (especially when we can build on m1 arm runners), we just would need a way to combine both builds and upload them at once under one tag.

@SchrodingersGat
Copy link
Member Author

I think at the end the matrix strategy is not a bad choice (especially when we can build on m1 arm runners), we just would need a way to combine both builds and upload them at once under one tag.

That sounds like a good idea for the next release

@SchrodingersGat SchrodingersGat merged commit 3b9fae6 into inventree:master Mar 2, 2024
21 checks passed
@SchrodingersGat SchrodingersGat deleted the docker-ci-fix branch March 2, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed CI CI / unit testing ecosystem docker Docker / docker-compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants