Fix undefined tabValue (#6470) #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Also fixes #6471 (issue duplicating the discussion) |
SchrodingersGat
added
bug
|
@XanderLuciano nice work, seems to work pretty well :) |
SchrodingersGat
approved these changes
Mar 13, 2024
|
Thank you! I'm Looking forward to submitting additional contributions towards the new react UI 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6470 Points out that the new UI nav bar does not correctly set the
;tabValueon initial page load.This is because
useParamswill return the params from the route as defined in the router. Our router does not define:tabValue/*for all routes so the object returned fromuseParamsdoes not have atabValueproperty and is therefore undefined on initial page load.This PR uses
useMatchto create a new URL match for:tabName/*and sets thetabValuevariable correctly.The result, is a navbar that always has the correct tab shown as active.