Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS for long details field #6739

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix CSS for long details field #6739

merged 1 commit into from
Mar 18, 2024

Conversation

SchrodingersGat
Copy link
Member

image

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Mar 18, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Mar 18, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 18, 2024 •
edited

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit bdbb100
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65f7a74a76e47200083d0e49
😎 Deploy Preview https://deploy-preview-6739--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat merged commit bf9dd16 into inventree:master Mar 18, 2024
24 checks passed
@SchrodingersGat SchrodingersGat deleted the field-fix branch March 18, 2024 03:02
wolflu05
wolflu05 reviewed Mar 18, 2024
View reviewed changes
src/frontend/src/components/details/Details.tsx
style={{
display: 'flex',
justifyContent: 'space-between',
wordBreak: 'break-word'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an alignItems: flex-start too, so that the icon, field name starts at the top of the container.

@SchrodingersGat SchrodingersGat mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolflu05 wolflu05 wolflu05 left review comments

Assignees
No one assigned
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

[PUI] Details Field Text Length
2 participants
@SchrodingersGat @wolflu05