Fix PUI build workflow #6754
Merged
Fix PUI build workflow #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
wolflu05
added
Platform UI
|
I think this should be backported too |
|
@wolflu05 do the translations get included in the compiled docker image currently? |
|
Yes, see https://github.com/inventree/InvenTree/blob/master/Dockerfile#L110 https://github.com/inventree/InvenTree/blob/master/tasks.py#L998 and if the wont be included, we would actually already have noticed with the docker image because that's used on demo and so much prod instances. The fact that this issue actually existed for so long time shows how rare such a bare metal, from code setup is. |
|
Thanks for confirming. And thanks for the fix! |
SchrodingersGat
added
setup
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
pushed a commit
to SchrodingersGat/InvenTree
that referenced
this pull request
Mar 19, 2024
* Fix PUI build workflow * Fix PUI build release workflow
Merged
SchrodingersGat
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #6727 it seems like we missed to include the compiled translations the whole time in the artifact builds. This PR adds the lingui compile step to the artifact and release build.
I suggest we could also back port this change to 0.14.x
EDIT: Tested the build produced by this run, works now.