Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few warnings in api generation #6836

Merged
merged 11 commits into from
Mar 24, 2024

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Mar 24, 2024

This addresses most „real“ warnings, nearly all remaining are operationId warnings - which I think we can ignore on a functional level.

It:

  • Removes the /plugin/activate/ endpoint - which does not seem to serve any purpose as there is a detail endpoint to active a plugin
  • Updates a few interpolated fields to typed definitions
  • fixes a lot of ModelChiceFilters with custom methods where the type could not be auto-asserted from string to integer (as they are pk-based)
  • Updates docstrings to reflect that a bunch of list endpoints also support (bulk) delete actions

@matmair matmair self-assigned this Mar 24, 2024
@matmair matmair added the api Relates to the API label Mar 24, 2024
Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 57dd9a7
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66007766d019b800084b1e90

@matmair matmair added this to the 0.15.0 milestone Mar 24, 2024
@matmair matmair marked this pull request as ready for review March 24, 2024 18:16
@matmair matmair marked this pull request as draft March 24, 2024 18:16
@matmair matmair marked this pull request as ready for review March 24, 2024 19:36
@SchrodingersGat SchrodingersGat merged commit 9a0c978 into inventree:master Mar 24, 2024
22 checks passed
@SchrodingersGat
Copy link
Member

Cheers @matmair

@matmair matmair deleted the fix-api-generation branch March 24, 2024 22:39
@SchrodingersGat
Copy link
Member

@matmair looks like this is failing in master now:

image

Any ideas?

@matmair
Copy link
Contributor Author

matmair commented Mar 25, 2024

Seems like a version miss-match - should be very easy to solve. Will create follow up PR

@SchrodingersGat
Copy link
Member

Hey @matmair for some reason this API schema file did not upload - see missing 185 here: https://github.com/inventree/schema/tree/main/export

This is causing subsequent PRs to fail:

https://github.com/inventree/InvenTree/actions/runs/8445857532/job/23133713488?pr=6866

Any ideas? Should we manually generate and upload version 185?

@matmair
Copy link
Contributor Author

matmair commented Mar 27, 2024

I have manually uploaded 185 - will look into the CI history why that did not update

matmair added a commit to inventree/schema that referenced this pull request Mar 27, 2024
@matmair
Copy link
Contributor Author

matmair commented Mar 27, 2024

The schema was not uploaded because of the bug fixed in #6837 - should work again as a fix for that is already merged

@SchrodingersGat
Copy link
Member

@matmair - while the new file has uploaded it seems that the action still is failing - see here for example:

https://github.com/inventree/InvenTree/actions/runs/8450808733/job/23147785222?pr=6871

@matmair
Copy link
Contributor Author

matmair commented Mar 27, 2024

i have manually fixed it - we have some issues in API generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants