Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test start, end date and test station to the next gen UI #6883

Conversation

martonmiklos
Copy link
Contributor

Following upon this:
#6149 (comment)

Here is a PR which adds the new test fields to the React UI.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit e200068
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6605ecd5fb90160009c26f0a
😎 Deploy Preview https://deploy-preview-6883--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat
Copy link
Member

While you are likely still working on this:

image

@martonmiklos
Copy link
Contributor Author

While you are likely still working on this:

Dauh, my bad. I will fix it tomorrow...

@martonmiklos martonmiklos force-pushed the add_additional_test_fields_to_react_ui branch from 10a14f8 to ce5e9a0 Compare March 28, 2024 21:33
@martonmiklos martonmiklos force-pushed the add_additional_test_fields_to_react_ui branch from ce5e9a0 to 1d40fb2 Compare March 28, 2024 21:36
@wolflu05
Copy link
Contributor

BTW, it would be great if you could stop force pushing as this may break review comments and makes it really hard to follow along the changes. Just push new changes as new commits, they are squash merged anyway.

@SchrodingersGat SchrodingersGat added stock Related to Stock models user interface User interface Platform UI Related to the React based User Interface labels Apr 1, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 1, 2024
@SchrodingersGat
Copy link
Member

LGTM - @wolflu05 are you happy with this also?

Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@wolflu05 wolflu05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@SchrodingersGat
Copy link
Member

@martonmiklos thanks for the contribution :)

@SchrodingersGat SchrodingersGat merged commit e04fd3d into inventree:master Apr 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface stock Related to Stock models user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants