Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security improvements #6890

Merged
merged 13 commits into from
Apr 2, 2024
Merged

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Mar 28, 2024

Some small improvements:

  • Moves content write permission into the job
  • Enables upload of OSSF scorecard in real-time
  • Pins QC/Docker dependencies to enhance reproducibility
  • Adds SonarCloud as a SAST provider replacing deepsource

Closes #6494

@matmair matmair added the CI CI / unit testing ecosystem label Mar 28, 2024
@matmair matmair self-assigned this Mar 28, 2024
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit a814ee4
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/660b98d0cf5af30008929c74
😎 Deploy Preview https://deploy-preview-6890--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair matmair marked this pull request as ready for review March 28, 2024 20:39
@matmair matmair added this to the 0.15.0 milestone Mar 28, 2024
@matmair matmair changed the title [WIP] Security improvements Security improvements Mar 30, 2024
@matmair
Copy link
Contributor Author

matmair commented Mar 30, 2024

This is ready for a review. For enabling SonarCloud @SchrodingersGat will have to approve the App Installation. In that step we can also remove the permissions for deepsource.

@SchrodingersGat
Copy link
Member

SchrodingersGat commented Apr 1, 2024

@matmair sonarcloud is now setup, and I am happy with this PR. Please advise if I should merge this in or wait for further steps

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@matmair
Copy link
Contributor Author

matmair commented Apr 2, 2024

@SchrodingersGat this is ready for merge now

@SchrodingersGat SchrodingersGat merged commit 4db61df into inventree:master Apr 2, 2024
21 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair-patch-1 branch April 2, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch SAST provider to improve CI stability
2 participants