Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile fixes #6905

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Dockerfile fixes #6905

merged 1 commit into from
Apr 2, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Change "as" to "AS"
  • Exposed by sonarcloud analysis

@SchrodingersGat
Dockerfile fixes
09b3789 
- Change "as" to "AS"
@SchrodingersGat SchrodingersGat added docker Docker / docker-compose refactor labels Apr 2, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 2, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 09b3789
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/660b51fcfff7540008a6dc8b
😎 Deploy Preview https://deploy-preview-6905--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@SchrodingersGat
Copy link
Member Author

Note that sonarcloud has raised the "root user" issue - #6589

@SchrodingersGat SchrodingersGat merged commit c65f7dc into inventree:master Apr 2, 2024
23 of 24 checks passed
@SchrodingersGat SchrodingersGat deleted the dockerfile-fixes branch April 2, 2024 01:14
@matmair
Copy link
Contributor

matmair commented Apr 2, 2024

@SchrodingersGat sonarcloud is pretty good about detecting these kind of issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker Docker / docker-compose refactor
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SchrodingersGat @matmair