Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-money from 3.2.0 to 3.4.1 in /src/backend #6942

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 3, 2024

Bumps django-money from 3.2.0 to 3.4.1.

Release notes

Sourced from django-money's releases.

Release 3.4.1

Full Changelog: https://django-money.readthedocs.io/en/latest/changes.html

Release 3.4

Full Changelog: https://django-money.readthedocs.io/en/latest/changes.html

Release 3.3

Fixed

  • Fix detection of necessary migrations. Note that this means that previously undetected migrations will be detected as of this version #725 (vanschelven)

Full Changelog: https://django-money.readthedocs.io/en/latest/changes.html

Changelog

Sourced from django-money's changelog.

3.4.1_ - 2023-11-30

Fixed

  • The default setting for CURRENCY_CHOICES excluded the currency choice defined by DEFAULT_CURRENCY. :github-issue:739 (:github-user:Naggafin)

3.4_ - 2023-10-17

.. note::

If you are using Django REST Framework or any other mechanism that relies on a custom serializer, please note that you now manually have to register the serializer. See :ref:this code snippet <index:Note on serialization>.

Changed

  • Don't register Django Money serializers by default, instead the user should actively register a serializer in the settings.py :github-issue:636 (:github-user:emorozov)

3.3_ - 2023-09-10

Fixed

  • Fix detection of necessary migrations. Note that this means that previously undetected migrations will be detected as of this version :github-issue:725 (:github-user:vanschelven)

3.2_ - 2023-07-03

Changed

  • Explicitly define id in djmoney.contrib.exchange.Rate model - This ensures that the database table will use AutoField even if DEFAULT_AUTO_FIELD is set to BigAutoField in the Django project's settings #716

Fixed

  • Downgrade asgiref to 3.6 to work with pypy3

3.1_ - 2023-04-20

Added

  • Python 3.11 support :github-issue:700 (:github-user:sdarmofal)
  • Django 4.2 support :github-issue:700 (:github-user:sdarmofal)
  • Pyright support for .pyi files :github-issue:686 (:github-user:karolyi)
  • Support for Coalesce :github-issue:678 (:github-user:stianjensen)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [django-money](https://github.com/django-money/django-money) from 3.2.0 to 3.4.1.
- [Release notes](https://github.com/django-money/django-money/releases)
- [Changelog](https://github.com/django-money/django-money/blob/main/docs/changes.rst)
- [Commits](django-money/django-money@3.2...3.4.1)

---
updated-dependencies:
- dependency-name: django-money
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependency Relates to a project dependency python Pull requests that update Python code labels Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 4d83114
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/660d2b028a611d0008f8f7d3

@SchrodingersGat SchrodingersGat merged commit 5548254 into master Apr 3, 2024
38 checks passed
@SchrodingersGat SchrodingersGat deleted the dependabot/pip/src/backend/django-money-3.4.1 branch April 3, 2024 10:56
@SchrodingersGat
Copy link
Member

Although this passed CI, it has failed docker build as the migrations checks were skipped here.

https://github.com/inventree/InvenTree/actions/runs/8537505517/job/23389035648

We will need to fix this, and also potentially look at ensuring that the migration checks are run if backend dependencies change...

@matmair
Copy link
Contributor

matmair commented Apr 3, 2024

The fix seems to be more involved, I would roll back this merge for now

matmair added a commit to matmair/InvenTree that referenced this pull request Apr 3, 2024
@SchrodingersGat
Copy link
Member

@matmair I see you have included this rollback in #6855

@matmair
Copy link
Contributor

matmair commented Apr 3, 2024

@SchrodingersGat yes to get the CI running again

@matmair matmair mentioned this pull request Apr 3, 2024
3 tasks
SchrodingersGat added a commit that referenced this pull request Apr 3, 2024
* compile a license texts bundle

* add backend license extraction on install

* change path for licenses

* add to gitignore

* Add api to expose license paths

* add texts

* add frontend rendering of licensing files

* Handle errors when fetching license information

* Format backend packages.txt in json

* Improved API rendering:

- Handle file errors
- Render as JSON object

* Improve frontend modal rendering

- Separate frontend / backend into tabs
- Split packages into accordion

* Generate JSON file for fronten deps

* Fix rendering for frontend deps

* Update src/frontend/src/components/modals/LicenseModal.tsx

Co-authored-by: Lukas <76838159+wolflu05@users.noreply.github.com>

* Update src/frontend/src/components/modals/LicenseModal.tsx

Co-authored-by: Lukas <76838159+wolflu05@users.noreply.github.com>

* make reading of licenses objects dynamic

* remove unsued import

* style fixes

* style fixes

* default to first value

* use new syntax to call docker compose

* merge fix

* fix path

* Roll back #6942

* Update qc_checks.yaml

Run migration checks when requirements file changes

---------

Co-authored-by: Oliver Walters <oliver.henry.walters@gmail.com>
Co-authored-by: Lukas <76838159+wolflu05@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Relates to a project dependency python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants