Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Increase migration test coverage #6995

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Apr 10, 2024

This PR aims to improve carryforward coverage of migration (tests). WIP

@matmair matmair added the CI CI / unit testing ecosystem label Apr 10, 2024
@matmair matmair added this to the 0.15.0 milestone Apr 10, 2024
@matmair matmair self-assigned this Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit b1daa03
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66171f06ad27ed00070070eb

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (1e0382c) to head (b1daa03).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6995      +/-   ##
==========================================
+ Coverage   84.24%   85.98%   +1.73%     
==========================================
  Files         875      875              
  Lines       40863    40863              
  Branches      284      284              
==========================================
+ Hits        34426    35136     +710     
+ Misses       6364     5654     -710     
  Partials       73       73              
Flag Coverage Δ
backend 85.44% <ø> (+<0.01%) ⬆️
migrations 42.56% <ø> (?)
pui 49.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair added the full-run Always do a full QC CI run label Apr 10, 2024
@matmair matmair marked this pull request as ready for review April 10, 2024 23:35
@matmair matmair marked this pull request as draft April 10, 2024 23:35
@matmair matmair closed this Apr 10, 2024
@matmair matmair reopened this Apr 10, 2024
@matmair matmair marked this pull request as ready for review April 11, 2024 00:05
@matmair matmair changed the title WIP: [CI] Increase migration test coverage [CI] Increase migration test coverage Apr 11, 2024
@matmair
Copy link
Contributor Author

matmair commented Apr 11, 2024

Ready for review, adds migration coverage to baseline backend coverage

@SchrodingersGat SchrodingersGat merged commit 6b858f7 into inventree:master Apr 11, 2024
49 of 51 checks passed
@SchrodingersGat SchrodingersGat deleted the ci-migration-check-triggers branch April 11, 2024 00:11
@SchrodingersGat
Copy link
Member

@matmair thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem full-run Always do a full QC CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants