Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin shell #6998

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Admin shell #6998

merged 4 commits into from
Apr 11, 2024

Conversation

SchrodingersGat
Copy link
Member

Adds optional integration with django-debug-shell

  • Allows optional shell access in development mode, for users with superuser access
  • Requires DEBUG mode to be enabled (disabled for production)
  • Requires environment var / configuration parameter to be set
  • Package is not installed as part of default requirements (but is as part of dev-requirements)

@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit eeec9f8
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6617b587a1ba300008a2a560

@matmair
Copy link
Contributor

matmair commented Apr 11, 2024

@SchrodingersGat we might want to include a check if the package is installed in the env and write a warning if not - so that there is no confusion why it is not functioning.

@SchrodingersGat
Copy link
Member Author

SchrodingersGat commented Apr 11, 2024

@matmair in such a case there is a very obvious error message:

image

IMO this is very much a developer-only feature, and you have to go through a lot of steps to actively enable it - so, one would assume that in such a case the provided error is sufficient?

@SchrodingersGat
Copy link
Member Author

Never mind, added it.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.97%. Comparing base (6b858f7) to head (eeec9f8).
Report is 1 commits behind head on master.

Files Patch % Lines
src/backend/InvenTree/InvenTree/settings.py 36.36% 7 Missing ⚠️
src/backend/InvenTree/InvenTree/urls.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6998      +/-   ##
==========================================
- Coverage   85.98%   85.97%   -0.02%     
==========================================
  Files         875      875              
  Lines       40867    40880      +13     
  Branches      284      284              
==========================================
+ Hits        35140    35145       +5     
- Misses       5654     5662       +8     
  Partials       73       73              
Flag Coverage Δ
backend 85.42% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 485045e into inventree:master Apr 11, 2024
26 of 28 checks passed
@SchrodingersGat SchrodingersGat deleted the admin-shell branch April 11, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants