Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix currency rendering in order tables #7066

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

SchrodingersGat
Copy link
Member

If an order does not have a defined currency, the currency should fall back to the currency for the associated company.

This was not happening, but it is now!

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed order Related to purchase orders / sales orders user interface User interface pricing Pricing functionality Platform UI Related to the React based User Interface labels Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 2693082
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6621e6534009ed00081614a1

@SchrodingersGat SchrodingersGat added backport Apply this label to a PR to enable auto-backport action backport-to-0.14.x labels Apr 19, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (c823f14) to head (2693082).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7066      +/-   ##
==========================================
- Coverage   83.17%   83.17%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       45514    45515       +1     
  Branches     1254     1254              
==========================================
  Hits        37856    37856              
- Misses       7405     7406       +1     
  Partials      253      253              
Flag Coverage Δ
backend 85.42% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit cd53f21 into inventree:master Apr 19, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the order-currency-fix branch April 19, 2024 03:59
Copy link
Contributor

💔 All backports failed

Status Branch Result
0.14.x Backport failed because of merge conflicts

You might need to backport the following PRs to 0.14.x:
- Site access updates (#6731)

Manual backport

To create the backport manually run:

backport --pr 7066

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit to SchrodingersGat/InvenTree that referenced this pull request Apr 19, 2024
* Add "currency" to CompanyBriefSerializer

* Fix nav.js bug - potential illegal chars in panel name

* Update CUI tables

* Update PUI tables

* Bump API version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed order Related to purchase orders / sales orders Platform UI Related to the React based User Interface pricing Pricing functionality user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant