Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUI info banner to CUI #7097

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Apr 22, 2024

This adds callouts and links to PUI at several points in CUI. Can be disabled with a customize setting.
grafik
grafik
grafik

Closes #6554

@matmair matmair added enhancement This is an suggested enhancement or new feature user interface User interface Platform UI Related to the React based User Interface labels Apr 22, 2024
@matmair matmair added this to the 0.15.0 milestone Apr 22, 2024
@matmair matmair self-assigned this Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 819194a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66278fb4a767a90008140758

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (50ca493) to head (0ed8cd2).
Report is 8 commits behind head on master.

❗ Current head 0ed8cd2 differs from pull request most recent head 819194a. Consider uploading reports for the commit 819194a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7097      +/-   ##
==========================================
- Coverage   83.24%   82.70%   -0.55%     
==========================================
  Files        1038     1038              
  Lines       45493    46244     +751     
  Branches     1244     1244              
==========================================
+ Hits        37869    38244     +375     
- Misses       7377     7753     +376     
  Partials      247      247              
Flag Coverage Δ
backend 85.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

Can we use a different wording? Do you mean interstitial? Perhaps "banner" would be better?

@matmair
Copy link
Contributor Author

matmair commented Apr 23, 2024

Sure, not married to any wording. I have changed all occurrences. My english is not the yellow of the egg sometimes https://www.youtube.com/shorts/0jAGDb5pXzs ;-)

Fixes inventree#6554

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
@matmair matmair changed the title Add intrestials to CUI Add PUI info banner to CUI Apr 23, 2024
@SchrodingersGat SchrodingersGat merged commit 37956db into inventree:master Apr 23, 2024
22 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue6554 branch April 23, 2024 11:05
@SchrodingersGat
Copy link
Member

Cheers @matmair for the yellow of the egg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to the new ui in the old ui like try this out in the new ui @wolflu05
2 participants