-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Test for errors in console #7114
[PUI] Test for errors in console #7114
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7114 +/- ##
==========================================
+ Coverage 83.44% 83.81% +0.36%
==========================================
Files 1039 1039
Lines 45731 45732 +1
Branches 1279 1279
==========================================
+ Hits 38162 38328 +166
+ Misses 7285 7111 -174
- Partials 284 293 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@SchrodingersGat this is ready for review; the non-covered code from the patch would require a lengthy new test suite so I would like to cover this at a later point |
Thanks @matmair this is a great addition to the testing framework |
@SchrodingersGat trying to get PUI testing baseline build out as hard as I can ;-) |
This PR adds a fixture to the base test to ensures that not errors are raised on the console.
It also fixes a few common errors:
A few errors are ignored for reporting:
ERR:
- those are mainly fetching actions, which are taken at the start of a user sessions and might still be unauthenticated