-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Notes editor #7284
[PUI] Notes editor #7284
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7284 +/- ##
==========================================
- Coverage 83.84% 83.36% -0.48%
==========================================
Files 1055 1056 +1
Lines 46276 47007 +731
Branches 1390 1390
==========================================
+ Hits 38799 39187 +388
- Misses 7113 7454 +341
- Partials 364 366 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@SchrodingersGat what is the difference between MDXEditor and the editor we are currently using? |
- Upload model type and model ID information
I would be really interested on the answer as well. |
However diving into "image resize" a bit more, that requires custom |
As a separate issue I would like to explore removing the "notes" from the API endpoints where they currently reside, and put them into separate endpoints (like "metadata"). The "notes" fields can potentially house a lot of data and I do not see the benefit of serializing each notes field for every item when we are generating a list of items... |
- Click on the right buttons - Add 'key' properties
- Pop the field for 'list' endpoints - Keep for detail
* Update API level for "modern" report templates * Update unit tests Ref: inventree/InvenTree#7284
TODO
Future Work