Stock count fix #738
Merged
Stock count fix #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is required to fix some issues with query aggregations as "distinct=True" cannot be set for Sum operations until django 3.0 - Multiple annotations on the same queryset were returning invalid results - Ref: https://code.djangoproject.com/ticket/10060 - Ref: https://docs.djangoproject.com/en/3.0/topics/db/aggregation/#combining-multiple-aggregations - django-dbbackup required updating for django3 support - django-qr-code for now is disabled, a new solution needs to be worked out
- Ensure that "distinct=True" is set! - ARRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
- Perform a single call to get starred parts for current user and record results - This provides significant speed improvements - Remove old manual serializer - More data prefetching
Official package does not (yet) support django 3.0
- django-mptt required updating to fix a bug where tree was not being rebuild on item save
New tablib is broked (at least in the admin interface)
- Some more work needed here to cut down on database hits
- Display django version in "about" dialog
- Not working in travis for some reason? - But they are working locally...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, what a ride!
This PR is a fix for #723 which appeared to be a simple bug but as it turns out, it was quite complicated:
There exists a "bug" in django where multiple query annotations may cause the returned results to be corrupted (which is what was reported). The fix is to set
distinct=Truewhen forming the annotations.However, the
distinctparameter is not available for Sum aggregations until django3..SO: This PR also migrates to Django3
There were a few updates to dependencies required to make this work.
As an aside the refactoring work required to fix the reported bug has improved query efficiency and also Django3 seems to run a lot faster!
References