Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from using "make" to "invoke" #925

Merged
merged 11 commits into from Aug 21, 2020

Conversation

SchrodingersGat
Copy link
Member

  • Pythonic is best!
  • Removes requirement for "make" (which means install on Windows will be easier)

@SchrodingersGat SchrodingersGat merged commit de86418 into inventree:master Aug 21, 2020
@SchrodingersGat SchrodingersGat deleted the make-replace branch August 21, 2020 11:58
@eeintech
Copy link
Contributor

Nice switch, invoke looks neat!

@SchrodingersGat
Copy link
Member Author

Nice switch, invoke looks neat!

Yeah, looks a lot more powerful than make, and it removes a non-python dependency. Should be able to automate some more complex behaviors if we need to.

@eeintech
Copy link
Contributor

As a good copycat, I went on swap make with invoke for Ki-nTree too 😃
Those @task decorators made me think of Celery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants