Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codebase: Remove authentication sources code duplication #2610

Closed
8 tasks
dwlfrth opened this issue Sep 6, 2017 · 1 comment
Closed
8 tasks

codebase: Remove authentication sources code duplication #2610

dwlfrth opened this issue Sep 6, 2017 · 1 comment
Assignees
@jrouzierinverse
Labels
Priority: Medium Status: For review
Milestone
PacketFence-7.4

Comments

@dwlfrth
Copy link
Contributor

dwlfrth commented Sep 6, 2017 •
edited by whitx
Loading

Some part of authentication sources is duplicated due to the recent change of how to display them.

Please make sure to remove ALL duplicate code for ease of maintenance.

  • librairies
  • portal templates
  • admin templates
  • admin controllers
  • admin models
  • admin forms
  • bases
  • ...
@dwlfrth dwlfrth added this to the PacketFence-7.4 milestone Sep 6, 2017
@dwlfrth
Copy link
Contributor Author

dwlfrth commented Sep 6, 2017

Related to #2605

@jrouzierinverse jrouzierinverse mentioned this issue Sep 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrouzierinverse jrouzierinverse

Labels
Priority: Medium Status: For review
Projects
None yet
Milestone
PacketFence-7.4
Development

No branches or pull requests
2 participants
@dwlfrth @jrouzierinverse