Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sponsor guest registration: untranslated email #3670

Closed
nqb opened this issue Oct 10, 2018 · 4 comments
Closed

sponsor guest registration: untranslated email #3670

nqb opened this issue Oct 10, 2018 · 4 comments

Comments

@nqb
Copy link
Contributor

nqb commented Oct 10, 2018

To reproduce: Create a sponsor request by visiting captive portal with a web browser configured in French.

Actual result: Sponsor will receive an email with:

Expected result: Sponsor should receive email with subject and content in French.

Template contains I18n tags and chains are present in conf/locale/fr/LC_MESSAGES/packetfence.po

@nqb
Copy link
Contributor Author

nqb commented Oct 17, 2018

@jrouzierinverse: did you find something on this ?

@nqb
Copy link
Contributor Author

nqb commented Oct 19, 2018

BUMP

@jrouzierinverse
Copy link
Member

We set the language to the configured Language in PacketFence advanced.language not the language of The browser for sponsor emails.

https://github.com/inverse-inc/packetfence/blob/devel/lib/pf/activation.pm#L438

We need to decide on the proper behavior for which language to use when sending sponsor emails.

In my opinion it would be better to make sure that the language of the email is sent in the Language that is configured in PacketFence not in browser.
Because If I am visiting an office in Japan the person sponsoring my access should get an email in the language that is configured in PacketFence.
Not whatever happens to be configured in my browser.

jrouzierinverse added a commit to jrouzierinverse/packetfence that referenced this issue Oct 23, 2018
@nqb
Copy link
Contributor Author

nqb commented Oct 24, 2018

For the record, code in #3698 fixes only bad translation for the subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants