feature/go-pfmon #5613

jrouzierinverse · 2020-06-18T15:54:15Z

Description

A go based pfmon

NEWS file entries

New Features

go based pfmon

Delete branch after merge

NO

Checklist

Document the feature
Add unit tests
Add acceptance tests (TestLink)

Upgrade Instructions

Rename PFMON -> PFCRON

/usr/local/pf/bin/addons/upgrade/to-10.2-adminroles-conf.pl

julsemaan · 2020-07-17T11:51:39Z

One general comment I have about this is that the new binary shouldn't be called pfmaint since it can easily be confused with pf-maint.pl

We should keep the name pfmon

fdurand · 2020-07-17T12:04:35Z

Does the new pfmon binary is aware of the tasks it can run on all cluster members versus some of them who needs to run on only one server ?

jrouzierinverse · 2020-07-17T14:42:42Z

Does the new pfmon binary is aware of the tasks it can run on all cluster members versus some of them who needs to run on only one server ?

No, I will add support for running on only the master server since that is the current behavior of pfmon.

jrouzierinverse · 2020-07-21T11:49:03Z

It now only runs on the master in the cluster.

nqb · 2020-08-20T12:33:33Z

After this one is merged, will pfmon continues to exist or should we need to replace pfmon by pfcron in all places (for instance in documentation) ?

addons/dev-helpers/pfmon_to_maintenance.pl

go/cron/window_batch_task.go

go/cron/pfcronjob.go

go/cron/config.go

go/cron/cluster.go

go/cron/batch.go

fdurand · 2020-09-15T15:51:11Z

lib/pf/cmd/pf/pfmon.pm

@@ -67,71 +67,8 @@ pf::cmd::pf::pfmon

 use strict;
 use warnings;
-use pf::config::pfmon qw(%ConfigPfmon);


Why not just remove the file ?

I left it for backward compatibility of cron jobs.

lib/pf/file_paths.pm

jrouzierinverse · 2020-09-18T20:35:07Z

Please rereview

fdurand · 2020-09-21T17:46:20Z

go/cron/certificates_check_test.go

+import (
+	"testing"
+)
+


Does it make sense to test an expired certificate ?

fdurand · 2020-09-21T18:08:57Z

There is still references to pfmon in the code.

addons/backup-and-maintenance.sh
addons/monit/monit_checks_configurations/00_packetfence.tt
conf/log.conf.d/pfmon.conf.example
conf/monitoring/statsd.d/packetfence.conf.example
docs/PacketFence_Network_Devices_Configuration_Guide.asciidoc
docs/PacketFence_Clustering_Guide.asciidoc
docs/api/spec/openapi.yaml
lib/pf/constants/admin_roles.pm
....

What do we do with that ?

extrafu · 2020-09-22T11:34:54Z

@jrouzierinverse Advised on Fabrice's last comment and let's wrap this up once for all.

jrouzierinverse · 2020-09-22T20:24:17Z

Please re-review

addons/upgrade/to-10.2-adminroles-conf.pl

fdurand · 2020-09-22T20:46:03Z

On my side it looks ok, i let keep @julsemaan doing a last shot.

julsemaan · 2020-09-23T12:21:00Z

My comments were marked as resolved so I'm fine with this being merged

jrouzierinverse force-pushed the feature/go-pfmon branch from ef92e49 to 77475e4 Compare June 19, 2020 18:14

jrouzierinverse force-pushed the feature/go-pfmon branch 2 times, most recently from ed5b50e to 2036276 Compare June 30, 2020 19:44

jrouzierinverse force-pushed the feature/go-pfmon branch from 2036276 to 3928800 Compare July 8, 2020 13:41

jrouzierinverse force-pushed the feature/go-pfmon branch from 5fd4ccb to af64a79 Compare July 15, 2020 13:47

jrouzierinverse force-pushed the feature/go-pfmon branch from fdef9c7 to dd0b642 Compare July 21, 2020 10:36

jrouzierinverse force-pushed the feature/go-pfmon branch from 6d2a352 to 25ba88b Compare July 27, 2020 14:33

jrouzierinverse added this to the PacketFence-10.2 milestone Aug 10, 2020

jrouzierinverse force-pushed the feature/go-pfmon branch from 4c150f2 to 7baa98d Compare August 26, 2020 16:40

extrafu assigned fdurand and julsemaan Sep 9, 2020

julsemaan suggested changes Sep 9, 2020

View reviewed changes

jrouzierinverse added Type: Feature / Enhancement Status: For review labels Sep 9, 2020

fdurand reviewed Sep 15, 2020

View reviewed changes

lib/pf/file_paths.pm Outdated Show resolved Hide resolved

jrouzierinverse force-pushed the feature/go-pfmon branch 3 times, most recently from 30c4e89 to 33f61c6 Compare September 18, 2020 15:17

fdurand reviewed Sep 21, 2020

View reviewed changes

go/cron/certificates_check_test.go

import (

"testing"

)

Copy link

Member

fdurand Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to test an expired certificate ?

jrouzierinverse added 2 commits September 22, 2020 16:22

New Job Pfmon

092c0f4

New interface Job

c9335e9

jrouzierinverse and others added 19 commits September 22, 2020 16:23

Disable bandwidth_maintenance_session

70226b6

Remove interval

f4816f5

Only run pfcron task when there is not perl defined task

bfe4154

Check if type exists first

358cd2a

remove pfmon_config_file

5e988f3

change 60s to 1m

b2eabc1

Change 300s to 5m

24a9903

Log error

561d8b1

use the context passed

0491d02

Move cluster functions to it's own namespace

1b20630

Log error

dd6be84

Add test for Batch

e53d55d

Fixed debian packaging

bd3b91a

return if switch cannot be loaded

8db54e6

rename PFMON -> PFCRON

0f84015

Added addons/upgrade/to-10.2-adminroles-conf.pl

72014f4

Renamme pfmon to pfcron

c8f50da

Renamme pfmon to pfcron

fff7530

rename pfmon to pfcron

457f34b

jrouzierinverse force-pushed the feature/go-pfmon branch from 3b119e4 to 457f34b Compare September 22, 2020 20:23

fdurand requested changes Sep 22, 2020

View reviewed changes

addons/upgrade/to-10.2-adminroles-conf.pl Outdated Show resolved Hide resolved

addons/upgrade/to-10.2-adminroles-conf.pl Outdated Show resolved Hide resolved

Update description

e208bd5

fdurand merged commit 55baa6a into devel Sep 23, 2020

fdurand added a commit that referenced this pull request Sep 23, 2020

NEWS.ascidoc entry for #5613

4848f6d

nqb mentioned this pull request Sep 24, 2020

Debian installation failed after merge of 5613 #5823

Closed

satkunas pushed a commit that referenced this pull request Dec 11, 2020

NEWS.ascidoc entry for #5613

1c88b3b

satkunas deleted the feature/go-pfmon branch May 15, 2024 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/go-pfmon #5613

feature/go-pfmon #5613

jrouzierinverse commented Jun 18, 2020 •

edited

Loading

julsemaan commented Jul 17, 2020

fdurand commented Jul 17, 2020

jrouzierinverse commented Jul 17, 2020

jrouzierinverse commented Jul 21, 2020

nqb commented Aug 20, 2020

fdurand Sep 15, 2020

jrouzierinverse Sep 18, 2020

jrouzierinverse commented Sep 18, 2020

fdurand Sep 21, 2020

fdurand commented Sep 21, 2020

extrafu commented Sep 22, 2020

jrouzierinverse commented Sep 22, 2020

fdurand commented Sep 22, 2020

julsemaan commented Sep 23, 2020

feature/go-pfmon #5613

feature/go-pfmon #5613

Conversation

jrouzierinverse commented Jun 18, 2020 • edited Loading

Description

NEWS file entries

New Features

Delete branch after merge

Checklist

Upgrade Instructions

Rename PFMON -> PFCRON

julsemaan commented Jul 17, 2020

fdurand commented Jul 17, 2020

jrouzierinverse commented Jul 17, 2020

jrouzierinverse commented Jul 21, 2020

nqb commented Aug 20, 2020

fdurand Sep 15, 2020

Choose a reason for hiding this comment

jrouzierinverse Sep 18, 2020

Choose a reason for hiding this comment

jrouzierinverse commented Sep 18, 2020

fdurand Sep 21, 2020

Choose a reason for hiding this comment

fdurand commented Sep 21, 2020

extrafu commented Sep 22, 2020

jrouzierinverse commented Sep 22, 2020

fdurand commented Sep 22, 2020

julsemaan commented Sep 23, 2020

jrouzierinverse commented Jun 18, 2020 •

edited

Loading