feature/default-switch-packetfence-standard

[jrouzierinverse]

Description

Set the default switch type to Packetfence::Standard

NEWS file entries

Enhancements

• Set the default switch type to Packetfence::Standard
• Create a PacketFence::SNMP switch to force reevaluate access using SNMP

Issue

fixes #5490

Delete branch after merge

NO

UPGRADE file entries

Set the switch type to Generic if it was not previously defined.

/usr/local/pf/addons/upgrade/to-10.2-default-switch-packetfence-standard.pl

Checklist

• Document the feature
• Add unit tests
• Add acceptance tests (TestLink)

[nqb]

There is an ambiguity for addons/upgrade/to-10.2-default-switch-packetfence-standard.pl script.

Name of script doesn't match its description: "Rename Generic switch type to Packetfence::SNMP" and its actions: script is trying to set Generic value for switches.

[jrouzierinverse]

Fixed the verbage

[nqb]

Should we not remove Generic switch module too ?

[nqb]

If we want to replace Generic switch module by PacketFence::Standard switch module, we should first merge #5708, rebase and add cliAuthorizeRead and cliAuthorizeWrite scopes to PacketFence::Standard switch module based on what we do in Generic switch module.

I can take care of this change.

[jrouzierinverse]

Let's remove the Generic switch in 11.0.

[jrouzierinverse]

There is no need to add cliAuthorizeRead and cliAuthorizeWrite scopes to PacketFence::Standard.
As it has the same behavior of the Generic module if none are defined.