fix(docs): remove deduped html/images files #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqb
suggested changes
Jun 24, 2021
There was a problem hiding this comment.
- I suggest we keep
imagestarget inMakefileeven if it's only used by Debian and we continue to call Makefile fromdebian/rules. Paths inimagestarget need to be updated to reflect that change. - At the moment, on a Debian 9 installation,
/usr/local/pf/docsand/usr/local/pf/docs/imagesare already installed bypacketfencepackage, not bypacketfence-docpackage. Certainly because we take almost all content of git repository to create Debianpacketfencepackage, see debian/rules.
|
@nqb I pushed the changes. |
nqb
approved these changes
Jul 6, 2021
nqb
added a commit
that referenced
this pull request
Jul 7, 2021
nqb
added a commit
that referenced
this pull request
Jul 7, 2021
satkunas
pushed a commit
that referenced
this pull request
Jul 7, 2021
satkunas
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of copying the HTML files of the documentation to a different directory, expose the source directory of the documentation from Caddy.
Delete branch after merge
NO