Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating/modifying/deleting a syslog forwarder should prompt to restart rsyslog in the admin #6532

Closed
julsemaan opened this issue Aug 20, 2021 · 7 comments · Fixed by #7419
Closed

Comments

@julsemaan
Copy link
Collaborator

Describe the bug
Creating/modifying/deleting a syslog forwarder should prompt to restart rsyslog in the admin

To Reproduce

  1. Create a new syslog forwarder entry in the admin interface
  2. It isn't active until you restart rsyslog via the command line

Expected behavior
Like the other admin sections, it should prompt to restart rsyslog when doing an operation on the entry
There is an API call for that:
pfperl-api get -M POST /api/v1/system_service/rsyslog/restart

@nqb
Copy link
Contributor

nqb commented Aug 20, 2021

As mentioned in our documentation, you also need to run /usr/local/pf/bin/pfcmd generatesyslogconfig.

I don't think we have an API call for that and I think that restarting rsyslog will not put your configuration in production.

@julsemaan
Copy link
Collaborator Author

When you restart rsyslog, it regenerates the configuration

@satkunas
Copy link
Contributor

@julsemaan The API responses from /api/v1/system_service/:service/:method and /api/v1/service/:service/:method differ. I won't be able to offer a service button for rsyslog that behaves the same as the others until the former API call has some changes made. Since these changes might cause regressions in the configurator I will defer on adding the usual service button for now, and instead offer a single "Regenerate Config" button for the time being.

@julsemaan
Copy link
Collaborator Author

Lets just put a warning on top of the section like in the Event loggers

@satkunas
Copy link
Contributor

@julsemaan done. I left this issue open so we can reassign the milestone and revisit again later.

@julsemaan
Copy link
Collaborator Author

Moved the milestone and marked this as a feature instead of a bug

@julsemaan julsemaan removed this from the PacketFence-11.1 milestone Apr 15, 2022
@satkunas
Copy link
Contributor

A different endpoint (system_service) needs to be used for rsyslog, monit and mariadb.

Don't expose them on the services page.

We can put them in each section that needs them as single-service buttons-only.

@satkunas satkunas added this to the PacketFence-12.1 milestone Aug 25, 2022
@julsemaan julsemaan removed this from the PacketFence-12.1 milestone Nov 30, 2022
satkunas added a commit that referenced this issue Dec 8, 2022
satkunas added a commit that referenced this issue Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants