Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/6766 #6773

Merged
merged 5 commits into from
Dec 24, 2021
Merged

Fix/6766 #6773

merged 5 commits into from
Dec 24, 2021

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented Dec 14, 2021

Description

Added a way to defined the tls min and max version in the tls profil

Impacts

Eap configuration

Issue

fixes #6766

Delete branch after merge

YES

Checklist

  • Document the feature
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

Bug Fixes

@fdurand fdurand added this to the +1 (patch release) milestone Dec 14, 2021
@fdurand fdurand requested a review from nqb December 14, 2021 15:49
nqb
nqb reviewed Dec 15, 2021
View reviewed changes
conf/radiusd/tls.conf.defaults Outdated Show resolved Hide resolved
nqb
nqb reviewed Dec 15, 2021
View reviewed changes
conf/radiusd/tls.conf.defaults Outdated Show resolved Hide resolved
nqb
nqb suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@nqb nqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should also add notes in upgrade guide:

  • TLS 1.0 and TLS 1.1 are disabled by default
  • How to change default behavior

I can take care of that.

@nqb nqb mentioned this pull request Dec 15, 2021
Closed
3 tasks
@nqb
Copy link
Contributor

nqb commented Dec 15, 2021

I need to write upgrade note.

@nqb nqb merged commit 41240c6 into devel Dec 24, 2021
@nqb nqb deleted the fix/6766 branch December 24, 2021 10:08
@nqb
Copy link
Contributor

nqb commented Dec 24, 2021

I will backport to maintenance in January.

nqb added a commit that referenced this pull request Jan 3, 2022
@nqb
apply #6773 to maintenance
6ee494a
nqb added a commit that referenced this pull request Jan 3, 2022
@nqb
apply #6773 to maintenance
5430ba5
nqb added a commit that referenced this pull request Jan 6, 2022
@nqb
news for #6773
6dd4f9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqb nqb nqb requested changes

@satkunas satkunas Awaiting requested review from satkunas

@lzammit lzammit Awaiting requested review from lzammit

Assignees
No one assigned
Labels
Priority: High Status: For review Type: Bug
Projects
None yet
Milestone
+1 (patch release)
Development

Successfully merging this pull request may close these issues.

TLS 1.0 and 1.1 are disabled in FreeRADIUS configuration starting from PacketFence v11
2 participants
@fdurand @nqb