-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/6766 #6773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqb
reviewed
Dec 15, 2021
nqb
reviewed
Dec 15, 2021
nqb
reviewed
Dec 15, 2021
html/pfappserver/lib/pfappserver/Form/Config/Radiusd/TLSProfile.pm
Outdated
Show resolved
Hide resolved
nqb
suggested changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we should also add notes in upgrade guide:
- TLS 1.0 and TLS 1.1 are disabled by default
- How to change default behavior
I can take care of that.
I need to write upgrade note. |
I will backport to maintenance in January. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a way to defined the tls min and max version in the tls profil
Impacts
Eap configuration
Issue
fixes #6766
Delete branch after merge
YES
Checklist
NEWS file entries
Bug Fixes