pfconnector install.sh not working in version 12.0

[chises]

Describe the bug
If you follow the guide on https://www.packetfence.org/doc/PacketFence_Installation_Guide.html#_packetfence_connector you will fail with the follwing message:

bash install.sh
--2022-10-27 20:41:54--  https://go.dev/dl/go1.18.linux-amd64.tar.gz
Resolving go.dev (go.dev)... 216.239.36.21, 216.239.38.21, 216.239.34.21, ...
Connecting to go.dev (go.dev)|216.239.36.21|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://dl.google.com/go/go1.18.linux-amd64.tar.gz [following]
--2022-10-27 20:41:54--  https://dl.google.com/go/go1.18.linux-amd64.tar.gz
Resolving dl.google.com (dl.google.com)... 172.217.16.206, 2a00:1450:4001:80f::200e
Connecting to dl.google.com (dl.google.com)|172.217.16.206|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 141702072 (135M) [application/x-gzip]
Saving to: ‘go1.18.linux-amd64.tar.gz’

go1.18.linux-amd64.tar.gz                      100%[===================================================================================================>] 135.14M   125MB/s    in 1.1s

2022-10-27 20:41:55 (125 MB/s) - ‘go1.18.linux-amd64.tar.gz’ saved [141702072/141702072]

Cloning into 'packetfence'...
remote: Enumerating objects: 456831, done.
remote: Counting objects: 100% (143/143), done.
remote: Compressing objects: 100% (103/103), done.
remote: Total 456831 (delta 58), reused 70 (delta 36), pack-reused 456688
Receiving objects: 100% (456831/456831), 343.58 MiB | 25.17 MiB/s, done.
Resolving deltas: 100% (340873/340873), done.
Updating files: 100% (7347/7347), done.
cp: cannot stat 'conf/systemd/packetfence-pfconnector-remote.service': No such file or directory

To Reproduce
Steps to reproduce the behavior:

1. curl -O https://raw.githubusercontent.com/inverse-inc/packetfence/maintenance/12.0/addons/pfconnector/install.sh
2. bash install.sh

Screenshots

Expected behavior
Installation should be done successful

Desktop (please complete the following information):

• OS: Debian Bullseye

Additional context
the file conf/systemd/packetfence-pfconnector-remote.service is not present in version 12.0. I am not sure if the name changed to packetfence-pfconnector-client.service

[chises]

Update: I downloaded the version12 zip file manually extracted it and executed the install.sh command adjusted to the downloaded folder. This is working:

#!/bin/bash

set -o nounset -o pipefail -o errexit

build_dir=$(mktemp -d)
cd $build_dir

wget https://go.dev/dl/go1.18.linux-amd64.tar.gz
tar -xzf go1.18.linux-amd64.tar.gz
PATH="$(pwd)/go/bin:$PATH"

wget https://codeload.github.com/inverse-inc/packetfence/zip/refs/tags/v12.0.0
unzip v12.0.0
cd packetfence-12.0.0

cp conf/systemd/packetfence-pfconnector-remote.service /etc/systemd/system/
systemctl daemon-reload
systemctl enable packetfence-pfconnector-remote.service
systemctl stop packetfence-pfconnector-remote.service

cd go/
make pfconnector
cp pfconnector /usr/local/bin/
cd -

cp addons/pfconnector/configure.sh /usr/local/bin/pfconnector-configure

chmod +x /usr/local/bin/pfconnector*

echo "Connector installation completed"

this should work.

[nqb]

Hello,
Thanks for your report.
I just push a fix which should be directly available (same recipe as you propose)