Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate access after a role change in web ui #117

Closed
wants to merge 2 commits into from
Closed

Reevaluate access after a role change in web ui #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e1bfd1
Reevaluate access after a role change in web ui
julsemaan Nov 28, 2013
e035f6e
Takes care of null roles
julsemaan Nov 29, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion html/pfappserver/lib/pfappserver/Model/Node.pm
View file
Open in desktop
Expand Up @@ -247,10 +247,18 @@ sub update {
$result = node_modify($mac, %{$node_ref});
}
if ($result) {
if ($previous_node_ref->{status} ne $node_ref->{status}) {
if ($previous_node_ref->{status} ne $node_ref->{status} || $previous_node_ref->{category} ne $node_ref->{category}) {
# Node has been registered or deregistered
reevaluate_access($mac, "node_modify");
}
elsif (defined $previous_node_ref->{category} != defined $node_ref->{category}){
# Node role has been changed from null to defined or defined to null
reevaluate_access($mac, "node_modify");
}
elsif (defined $previous_node_ref->{category} && $previous_node_ref->{category} ne $node_ref->{category}){
# Node role has changed
reevaluate_access($mac, "node_modify");
}
}
else {
$status = $STATUS::INTERNAL_SERVER_ERROR;
Expand Down