feature/traplog-remove

[jrouzierinverse]

Description

Remove the traplog table

Impacts

pfsetvlan

Issue

Fixes #367

NEWS file entries

Delete branch after merge

NO

Upgrade file entries

The traplog table is now deprecated.
If wish to reclaim the space in the database.
The table should be manually removed.

[fdurand]

MAybe we can remove this dep

[fdurand]

upgrade-x-y-z -> drop table traplog;

[jrouzierinverse]

I thought that may not be the best thing to do.

I was going to suggest to add a note in the upgrade guide about removing it.

James Rouzier
jrouzier@inverse.ca :: +1.514.447.4918 (x115) :: http://www.inverse.ca
Inverse inc. :: Leaders behind SOGo (http://www.sogo.nu) and PacketFence (http://www.packetfence.org)

On 2016-10-28 8:24 PM, Durand wrote:

upgrade-x-y-z -> drop table traplog;

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1785 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmeMdDU8v8mcoqIihhhnahiTzvypwxzks5q4pIjgaJpZM4Kca65.

[julsemaan]

I think I'd agree with James on the drop. Some old mature environments might want to keep it.

If we do drop it in the upgrade script, we should add a note in the upgrade guide about it so people can backup the table before it gets deleted

[fdurand]

Rebase please

[jrouzierinverse]

Done

[louismunro]

Please add the note to the UPGRADE about this being deprecated.
That seems to be all that's missing to merge.

[jrouzierinverse]

Done

[louismunro]

I believe you must push the commit too...
😁

[jrouzierinverse]

Sorry which direction are we going.

• Deleting the traplog warning the users that they should back it up.
• Let it be and let the user remove it manually.

[jrouzierinverse]

Done