Feature/1797 register node return status

[dwlfrth]

Description

pf::node::node_register is able to return status message to inform end users on failure per example

Impacts

There shouldn't be any impact since we basically return a string along with the return code (0,1)
Should just make sure all the caller are handling the return code as they should (curl ?)
pf::node::node_register flow

• registration
• auto-registration
• wispr
• node import
• administration interface (user / nodes)
• portal
• vlan_filters (action = register_node)
• wmi (action = dynamic_register_node)

Delete branch after merge

YES

NEWS file entries

Enhancements

• Portal is giving more indication on node registration error

Bug Fixes

• pf::node::node_register | Refactor to add return code + status code/message (pf::node::node_register | Refactor to add return code + status code/message #1797)

[dwlfrth]

Please review

[julsemaan]

I'm not sure this really fixes #1797

It talks about showing the status page in the body but about reworking the node_register in the title.

Something is up...

[dwlfrth]

It partially fixes it in the sense that node_register will return a message to the portal.
Second part (subject of the issue) is more a customization and may be a good thing to be integrated in PacketFence codebase... having the message to display a link to the "status" page.

[dwlfrth]

Bump

[julsemaan]

Use the FALSE Luke

[julsemaan]

Just fix the constant and we're good to merge

[dwlfrth]

Sup !

[julsemaan]

https://www.youtube.com/watch?v=lgJsNW_zNUI&t=21

[extrafu]

Bump