Feature/emails template improvement #1823
Conversation
whitx
force-pushed
the
feature/emails-template-improvement
branch
2 times, most recently
from
714adf0
to
8b41e41
Compare
| msgstr "" | ||
|
|
||
| # html/captive-portal/templates/emails/emails-guest_local_account_creation.html | ||
| msgid "User Account" |
There was a problem hiding this comment.
User account already exists, please use it.
| msgid "Hostname" | ||
| msgstr "" | ||
|
|
||
| msgid "MAC address" |
There was a problem hiding this comment.
MAC Address already exists, please use it.
whitx
force-pushed
the
feature/emails-template-improvement
branch
from
5c86d63
to
67fa6f0
Compare
whitx
added
Status: For review
Type: Feature / Enhancement
and removed
Status: Not ready
labels
whitx
force-pushed
the
feature/emails-template-improvement
branch
from
3b8c08e
to
021f08c
Compare
|
Rebased |
|
Bump |
| my $logger = get_logger(); | ||
|
|
||
| use POSIX; |
There was a problem hiding this comment.
Probably better to define it on the top
| use POSIX; | ||
| my $user_locale = clean_locale(setlocale(POSIX::LC_MESSAGES)); | ||
| if ($type eq $SPONSOR_ACTIVATION) { | ||
| $logger->info('We are doing sponsor activation', $user_locale); |
| $options{INCLUDE_PATH} = "$conf_dir/templates/"; | ||
| $options{ENCODING} = "utf8"; | ||
|
|
||
| use POSIX; |
| my ($locale) = @_; | ||
| if( $locale =~ /^([A-Za-z_]+)\./ ) { | ||
| $locale = $1; | ||
| } |
There was a problem hiding this comment.
That's fine, we just want to get rid of any extra dot-delimited part.
There was a problem hiding this comment.
if there's no dot, $locale doesn't change :)
There was a problem hiding this comment.
Sure ? my $lang = clean_locale($self->app->session->{locale});
There was a problem hiding this comment.
i prefer to have something more explicit like:
sub clean_locale {
my ($locale) = @;
if( $locale =~ /^([A-Za-z]+)./ ) {
return $1;
}
return $locale;
}
There was a problem hiding this comment.
Oh! Just adding return $locale; would fix it.
|
Agree to merge |
Description
Allow the possibility to use translation for the emails template, also allow customizable emails template per portal profile.
Impacts
every flow that include eamil, billing, email source, sponsor, pre-registraiton, etc.
Issue
Fixes #1322
Delete branch after merge
NO
NEWS file entries
New Features
UPGRADE file entries