Feature/registration role violation #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdurand
requested changes
Jan 4, 2017
| my $node_role = $node_info->{category}; | ||
| # matching registration role for unregistered devices | ||
| if($node_info->{status} eq $pf::node::STATUS_UNREGISTERED) { | ||
| $node_role = "registration"; |
| # NOTE: options_roles is a method on form but that receives the field as the first argument | ||
| my %roles = options_roles($self); | ||
| # Roles that aren't technically roles (non-db), except for registration which matches unregistered devices | ||
| my %skip_roles = ( |
|
fixaide |
|
sank iou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to define the 'registration' role in violation whitelistable roles so it matches unregistered devices
Also prevents user from selecting whitelistable roles that can never match (macDetection,voice,inline,isolation)
Impacts
Violation role whitelisting
Issue
fixes #1278
Delete branch after merge
YES
NEWS file entries
Enhancements
UPGRADE file entries
When whitelisting roles in a violation, the registration role will now match unregistered devices where before it would never match. Make sure to go through violations that may include this role to make sure it is relevant.