Feature/validate sponsor #2995
Feature/validate sponsor #2995
Conversation
|
@julsemaan Review and merge if all right. |
|
IMO, it would be risky to merge feature PRs given our tests are already underway Unless we explicitly assign someone to retest sponsor once that is merged |
|
Ok let's push it to v8.1. |
|
BUMP |
| type => 'Toggle', | ||
| checkbox_value => 'yes', | ||
| unchecked_value => 'no', | ||
| label => 'Sponsor validation', |
There was a problem hiding this comment.
Please capitalize all words of the label.
| label => 'Sponsor validation', | ||
| default => pf::Authentication::Source::SponsorEmailSource->meta->get_attribute('validate_sponsor')->default, | ||
| tags => { after_element => \&help, | ||
| help => 'Do you want to authenticate the sponsor when he click on the link ?' }, |
There was a problem hiding this comment.
Don't use the interrogative form. I suggest the following:
Force sponsor to authenticate when validating a guest request.
|
I got this error after signing in as the sponsor: |
|
@atran-inverse , it looks to be related to that issue #3250 can you try it ? |
|
Feature is tested and working. |
Description
Enable or no if a sponsor need to authenticate when he click on the link to validate the access.
Impacts
No
Delete branch after merge
YES
NEWS file entries
Enhancements