feature/enable-disable-profiles #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it miss status parameter in the checkup. |
fdurand
requested changes
May 31, 2018
| checkbox_value => 'enabled', | ||
| unchecked_value => 'disabled', | ||
| tags => { after_element => \&help, | ||
| help => 'If profile is disabled it will not be presented to the user' }, |
There was a problem hiding this comment.
Not really true, a connection profile is instantiate in multiples cases.
So something like that: If profile is disabled it will not be used.
|
Updated |
|
Can you rebase ? |
jrouzierinverse
force-pushed
the
feature/enable-disable-profiles
branch
from
90682e0
to
e370013
Compare
|
Done |
fdurand
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow profiles to enabled/disabled
Impacts
Captive Portal/ ProfileFactory
Issue
Fixes #3170
NEWS file entries
Enhancements