Faster start #3213
Merged
Faster start #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdurand
force-pushed
the
feature/faster_start
branch
from
95067cd
to
972da8c
Compare
julsemaan
reviewed
May 22, 2018
| @@ -173,6 +173,7 @@ sub service_exists { | |||
| my (@services) = @_; | |||
|
|
|||
| foreach my $service (@services) { | |||
| next if ($service eq 'pf'); | |||
There was a problem hiding this comment.
Does this remove the checkup when starting all PF services ?
If so, it doesn't sound that good since some people may miss out on major issues
There was a problem hiding this comment.
No it doesn't , here a sample when i restart pf:
fabian81:/usr/local/pf$ bin/pfcmd service pf restart
service|command
api-frontend|Service enabled
etcd|Service enabled
fingerbank-collector|Service enabled
haproxy-db|Service enabled
haproxy-portal|Service enabled
httpd.aaa|Service enabled
httpd.admin|Service enabled
httpd.collector|Service disabled
httpd.dispatcher|Service enabled
httpd.parking|Service enabled
httpd.portal|Service enabled
httpd.proxy|Service disabled
httpd.webservices|Service enabled
iptables|Service enabled
keepalived|Service enabled
netdata|Service enabled
pfbandwidthd|Service disabled
pfdetect|Service disabled
pfdhcp|Service enabled
pfdhcplistener|Service enabled
pfdns|Service enabled
pffilter|Service enabled
pfipset|Service enabled
pfmon|Service enabled
pfperl-api|Service enabled
pfqueue|Service enabled
pfsso|Service enabled
pfstats|Service enabled
radiusd-eduroam|Service enabled
radiusd-acct|Service enabled
radiusd-auth|Service enabled
radiusd-load_balancer|Service enabled
radiusd-cli|Service enabled
radsniff|Service enabled
redis_ntlm_cache|Service disabled
redis_queue|Service enabled
routes|Service disabled
snmptrapd|Service disabled
tc|Service enabled
winbindd|Service enabled
service|command
haproxy-db|stop
pf|stop
Could not write namespace config::PfDefault to L2 cache !
....
Could not write namespace resource::unified_api_system_user to L2 cache !
haproxy-db|start
Checking configuration sanity...
WARNING - template directory '/usr/local/pf/html/captive-portal/profile-templates/Wire' for profile Wire does not exist using default templates
WARNING - template directory '/usr/local/pf/html/captive-portal/profile-templates/Dot1x' for profile Dot1x does not exist using default templates
pf|start
There was a problem hiding this comment.
As they said in France:
"Superbe! maintenant allons chercher une baguette chez le boulanger"
fdurand
force-pushed
the
feature/faster_start
branch
from
86ad08f
to
6d1a4a9
Compare
|
Rebased, ready for the last review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up to 30s start faster.
Use the perl module to generate the configuration instead of pfcmd
Impacts
Systemd script
Delete branch after merge
YES
NEWS file entries
Enhancements