-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for 3069 #3261
Fix for 3069 #3261
Conversation
Should we offer backward compatibility? Ie., we keep supporting WIRED-MAC-AUTH but spew a message in the logs about this. |
I believe we would need to have an SQL statement in the upgrade script to rename the connection type in the locationlog |
Would the profile filters need to be changed also? |
Yes good point, there needs to be a script for that too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things to check out based on @jrouzierinverse comments and mine
BUMP |
UPGRADE.asciidoc
Outdated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
We merged the WIRED_MAC_AUTH and Ethernet-NoEAP to Ethernet-NoEAP so the configuration needs to be updated, to do that run: | ||
|
||
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" conf/profiles.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use absolute paths
BUMP |
UPGRADE.asciidoc
Outdated
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/vlan_filters.conf | ||
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/radius_filters.conf | ||
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/switch_filters.conf | ||
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/authentication.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it easier and reduce mistakes can you put all those into a single shell script.
rebase |
BUMP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also @jrouzierinverse's comment on the upgrade notes to see if we do or not
UPGRADE.asciidoc
Outdated
@@ -1794,3 +1794,15 @@ To upgrade the database schema, run the following command: | |||
Once completed, update the file /usr/local/pf/conf/currently-at to match the new release number (PacketFence X.Y.Z). | |||
|
|||
|
|||
/usr/local/pf/addons/upgrade/to-8.2-pfmon-conf.pl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't belong in this PR
BUMP |
Description
Ethernet-NoEAP and no WIRED-MAC-AUTH anymore
Impacts
No
Issue
fixes #3069
Delete branch after merge
YES
NEWS file entries
Bug Fixes