Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 3069 #3261

Merged
merged 6 commits into from
Oct 5, 2018
Merged

Fix for 3069 #3261

merged 6 commits into from
Oct 5, 2018

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented May 29, 2018

Description

Ethernet-NoEAP and no WIRED-MAC-AUTH anymore

Impacts

No

Issue

fixes #3069

Delete branch after merge

YES

NEWS file entries

Bug Fixes

@extrafu
Copy link
Member

extrafu commented May 30, 2018

Should we offer backward compatibility? Ie., we keep supporting WIRED-MAC-AUTH but spew a message in the logs about this.

@julsemaan
Copy link
Collaborator

I believe we would need to have an SQL statement in the upgrade script to rename the connection type in the locationlog

@julsemaan julsemaan self-requested a review May 30, 2018 20:05
@julsemaan julsemaan self-assigned this May 30, 2018
@jrouzierinverse
Copy link
Member

Would the profile filters need to be changed also?

@julsemaan
Copy link
Collaborator

@jrouzierinverse

Yes good point, there needs to be a script for that too

Copy link
Collaborator

@julsemaan julsemaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdurand

Few things to check out based on @jrouzierinverse comments and mine

@fdurand
Copy link
Member Author

fdurand commented Aug 20, 2018

BUMP

UPGRADE.asciidoc Outdated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
We merged the WIRED_MAC_AUTH and Ethernet-NoEAP to Ethernet-NoEAP so the configuration needs to be updated, to do that run:

sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" conf/profiles.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute paths

@fdurand
Copy link
Member Author

fdurand commented Aug 30, 2018

BUMP

UPGRADE.asciidoc Outdated
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/vlan_filters.conf
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/radius_filters.conf
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/switch_filters.conf
sed -i "s/WIRED_MAC_AUTH/Ethernet-NoEAP/g" /usr/local/pf/conf/authentication.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it easier and reduce mistakes can you put all those into a single shell script.

@jrouzierinverse
Copy link
Member

rebase

@fdurand
Copy link
Member Author

fdurand commented Oct 1, 2018

BUMP

Copy link
Collaborator

@julsemaan julsemaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also @jrouzierinverse's comment on the upgrade notes to see if we do or not

UPGRADE.asciidoc Outdated
@@ -1794,3 +1794,15 @@ To upgrade the database schema, run the following command:
Once completed, update the file /usr/local/pf/conf/currently-at to match the new release number (PacketFence X.Y.Z).


/usr/local/pf/addons/upgrade/to-8.2-pfmon-conf.pl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong in this PR

@fdurand
Copy link
Member Author

fdurand commented Oct 5, 2018

BUMP

@julsemaan julsemaan merged commit 2426cd0 into devel Oct 5, 2018
@julsemaan julsemaan deleted the fix/3069 branch October 5, 2018 14:47
julsemaan added a commit that referenced this pull request Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIRED_MAC_AUTH should be "merged" with Ethernet-NoEAP
4 participants