Fix/rogue detection #3514
Merged
Fix/rogue detection #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very interested in this patch. I'm getting spammed with rogue detection emails right now; about 60 - 70 messages per hour. |
fdurand
force-pushed
the
fix/rogue_detection
branch
from
52e3e28
to
aaaf27d
Compare
|
BUMP |
julsemaan
reviewed
Oct 1, 2018
lib/pf/dhcp/processor.pm
Outdated
| foreach my $network ( keys %NetworkConfig ) { | ||
| if ($NetworkConfig{$network}{'dhcpd'} eq 'enabled') { | ||
| push @local_dhcp_servers_ip, $NetworkConfig{$network}{'gateway'}; | ||
| push @local_dhcp_servers_ip, $NetworkConfig{$network}{'vip'} if ($NetworkConfig{$network}{'vip'}); |
|
Just fix the indentation issue and we're good to merge |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added all the ip of the server in the list of dhcp server to avoid false positive rogue dhcp detection
Impacts
No
Delete branch after merge
YES
NEWS file entries
Bug Fixes