Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sponsor choose access duration #4061

Merged
merged 9 commits into from
Aug 22, 2019
Merged

Sponsor choose access duration #4061

merged 9 commits into from
Aug 22, 2019

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented Mar 13, 2019 •
edited by nqb
Loading

Description

Allow the sponsor to choose the access duration
Define which authentication source used to verify that the sponsor is allowed to sponsor.

Impacts

Sponsor flow

Delete branch after merge

YES

Checklist

  • Document the feature
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

New Features

  • Allow the sponsor to choose the access duration
  • Define which authentication source used to verify that the sponsor is allowed to sponsor.

@fdurand fdurand added this to the PacketFence-8.4/9.0 milestone Mar 13, 2019
@extrafu
Copy link
Member

extrafu commented Mar 14, 2019

@jrouzierinverse To review and @lzammit to test.

@jrouzierinverse jrouzierinverse self-assigned this Mar 14, 2019
@jrouzierinverse
Copy link
Member

rebase

@fdurand fdurand force-pushed the feature/sponsor_choose_access_duration branch from f21817a to b774941 Compare March 25, 2019 15:38
@fdurand
Copy link
Member Author

fdurand commented Mar 25, 2019

Rebased.

@jrouzierinverse
Copy link
Member

Looks good @lzammit please test

@extrafu
Copy link
Member

extrafu commented Mar 25, 2019

@jrouzierinverse Correct me if I'm wrong here but the new GUI needs to be modified for this too. It'll have to be adjusted by @satkunas prior merging or immediately after.

@jrouzierinverse
Copy link
Member

Yes as it adds a new field in Sponsor sources

@jrouzierinverse jrouzierinverse force-pushed the feature/sponsor_choose_access_duration branch from 670f03b to b774941 Compare March 25, 2019 19:38
jrouzierinverse
jrouzierinverse approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@jrouzierinverse jrouzierinverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@julsemaan
Copy link
Collaborator

image

@fdurand
Copy link
Member Author

fdurand commented Mar 28, 2019

If approved , can we merge ?

@jrouzierinverse
Copy link
Member

Did Zammit test it?

@fdurand
Copy link
Member Author

fdurand commented Mar 28, 2019

Not part of his test to do.

@jrouzierinverse jrouzierinverse mentioned this pull request Apr 1, 2019
Closed
@nqb
Copy link
Contributor

nqb commented Apr 2, 2019

I update NEWS section of the description to add "Define which authentication source used to verify that the sponsor is allowed to sponsor", see #3631. Thanks @jrouzierinverse

@fdurand fdurand force-pushed the feature/sponsor_choose_access_duration branch from b774941 to e9b050c Compare May 27, 2019 19:11
@fdurand
Copy link
Member Author

fdurand commented May 28, 2019

@satkunas the new admin GUI needs to be adjusted for this PR

@fdurand
Copy link
Member Author

fdurand commented Jun 26, 2019

@satkunas can you help for the new admin ?

@fdurand fdurand force-pushed the feature/sponsor_choose_access_duration branch from e9b050c to b56d7f2 Compare July 16, 2019 18:05
@satkunas satkunas force-pushed the feature/sponsor_choose_access_duration branch from b56d7f2 to 60f3d3a Compare August 21, 2019 21:35
@fdurand
Copy link
Member Author

fdurand commented Aug 22, 2019

Retested from the new admin gui and register on the portal.
The code works on my side.
Ready to merge.

@extrafu
Copy link
Member

extrafu commented Aug 22, 2019

Should we move that to v9.1? It's currently targeted for 9.2.

@jrouzierinverse jrouzierinverse merged commit 201269a into devel Aug 22, 2019
@fdurand fdurand deleted the feature/sponsor_choose_access_duration branch September 23, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrouzierinverse jrouzierinverse jrouzierinverse approved these changes

@lzammit lzammit Awaiting requested review from lzammit

Assignees

@jrouzierinverse jrouzierinverse

@satkunas satkunas

Labels
Status: For review Type: Feature / Enhancement
Projects
None yet
Milestone
PacketFence-9.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fdurand @extrafu @jrouzierinverse @julsemaan @nqb @satkunas