Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVAS/GVM: Add a field for port list ID to support GVM (formerly OpenVAS) 20 #6082

Closed
wants to merge 4 commits into from
Closed

Conversation

aveao
Copy link

@aveao aveao commented Jan 7, 2021

Description

GVM (formerly OpenVAS) 20 adds a breaking change where it requires users to supply a PORT_LIST or PORT_RANGE UUID: https://docs.greenbone.net/API/GMP/gmp-20.08.html#changes

This PR adds an additional config field for that a la report format ID, alert ID, scan config ID:

This is currently a breaking patch where previous OpenVAS/GVM will break until they set a port list ID. Please let me know if any other behavior is expected and I will do my best to change the code to do that.

Impacts

  • OpenVAS (/GVM) compliance settings and scans

Issue

fixes #5791

Delete branch after merge

YES

Checklist

  • [yes] Document the feature
  • [n/a] Add unit tests
  • [n/a] Add acceptance tests (TestLink)

(Other fields lack unit tests and acceptance tests)

NEWS file entries

Bug Fixes

UPGRADE file entries

New OpenVAS field for port lists

In order to use the OpenVAS compliance checks, navigate to Configuration -> Port lists on GVM/OpenVAS's Web UI, select the port list you would like to use to scan the hosts, and add it to your OpenVAS scanner configuration.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2021

CLA assistant check
All committers have signed the CLA.

@aveao
Copy link
Author

aveao commented Jan 7, 2021

This is my first ever PR to PF, so my overall knowledge on how to contribute properly is limited. I did my best to read the relevant docs on both this repo and on the developer guide, but please let know if there's anything I missed and I'll do my best to fix it.

@LizardNerd
Copy link

I'm trying to integrate GVM 20.08 with PacketFence but I can't see the "Port list ID" section. Is this bug actually fixed? I'm running packetfence 10.2.0+20201007132254+199263253+0009+v10.2.0+stretch1. Thank you in advance.

@aveao
Copy link
Author

aveao commented Mar 3, 2021

@LizardNerd this PR is not yet merged into upstream, as such the bug is not yet fixed on packetfence releases like the one you have installed.

@LizardNerd
Copy link

LizardNerd commented Mar 4, 2021

@aveao I fixed the problem thanks to your changes. Anyway, there is still an issue whit "report_id" column on PF's MySQL database when I successfully start a scan trought PF, I think that for this reason, I can't get a report back from GVM 20.08 to PF. I've been puzzling over this issue for a week now.
Can I ask you for a hand? I enclose a zip with various logs and more. Really thank you if you can put an eye on this.

info_debug.zip

Some info:
PF management ip: 192.168.50.56
GVM 20.08: 192.168.50.228

P.s. At this point I'm doing the scan to 192.168.50.56 (PF) because I don't know how to scan IP on Registration, Isolation and Normal VLAN.

@syir-cjodex
Copy link

hello
Can someone help me with this..
I followed the fix but I couldn't find the directory /docs/api to modify the files
docs/api/spec/components/schemas/configscan.yaml
docs/api/spec/openapi.json
And as you can see I still don't have the option " port list ID" displayed
Is it because of these files ?
pf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openvas20.0.8 require port list id while creating target
4 participants