Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build vagrant images for integration tests #6099

Merged
merged 48 commits into from Mar 9, 2021
Merged

Conversation

nqb
Copy link
Contributor

@nqb nqb commented Jan 19, 2021

Description

Build ready-to-use Vagrant images for integration tests and send them to Vagrant cloud

Impacts

Integration tests
Pipeline

Delete branch after merge

YES

Checklist

  • Document the feature

NEWS file entries

Enhancements

  • Vagrant images for integration tests

@nqb nqb added this to the PacketFence-11.0 milestone Jan 19, 2021
@nqb nqb self-assigned this Jan 19, 2021
@nqb nqb force-pushed the feature/build-vagrant-images branch 3 times, most recently from f0d387c to 7acfe50 Compare January 21, 2021 06:28
@nqb nqb force-pushed the feature/build-vagrant-images branch from 2119534 to bfcfbd2 Compare January 31, 2021 11:11
@nqb nqb force-pushed the feature/build-vagrant-images branch from aeb4f2f to b4aff83 Compare February 10, 2021 06:54
@nqb nqb force-pushed the feature/build-vagrant-images branch 3 times, most recently from ecb8d4b to b31ad88 Compare February 25, 2021 14:54
@nqb nqb requested a review from JeGoi February 25, 2021 14:59
@nqb
Copy link
Contributor Author

nqb commented Feb 25, 2021

This PR is ready to be reviewed.

I still have an issue with CentOS boxes after build which I'm not able to understand. For now, I suggest we keep centos/7 boxes (I need to re-add upgrade_os.yml in addons/vagrant directory) and I will request help to CentOS community.

@nqb nqb removed their assignment Mar 2, 2021
@nqb
Copy link
Contributor Author

nqb commented Mar 2, 2021

I missed to disable SELinux before packaging box. Perhaps this is the root cause of my issue. Next pipeline triggered to check if it works.

@nqb nqb force-pushed the feature/build-vagrant-images branch from 3225074 to 9e95590 Compare March 2, 2021 11:43
Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fine for me.

Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better Now!
let's merge it

Add PR info 6099
@JeGoi JeGoi merged commit b4e7081 into devel Mar 9, 2021
@JeGoi JeGoi deleted the feature/build-vagrant-images branch March 9, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants