scroll devices in Intune to support counts over 1000 #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marking as not-ready since I'm just waiting on final confirmation of the fix |
| while($info && $info != $pf::provisioner::COMMUNICATION_FAILED && $info->{'@odata.nextLink'}) { | ||
| $info = $self->perform_get_device_info($mac, $info->{'@odata.nextLink'}); | ||
| if($info == $pf::provisioner::COMMUNICATION_FAILED) { | ||
| return $pf::provisioner::COMMUNICATION_FAILED; |
There was a problem hiding this comment.
If the previous messages succeeded shouldn't you just stop and return what was received prior instead of throw away all the previous messages?
There was a problem hiding this comment.
Yes we do throw it away so that it can be retried from scratch. Otherwise you could have an incomplete list if we would return what we already have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scroll devices in Intune to support counts over 1000 since Intune now requires that
Impacts
Intune integration
Delete branch after merge
YES
NEWS file entries
Enhancements