feature/remove-inline-accounting

[jrouzierinverse]

Description

Remove inline_accounting table.

NEWS file entries

Enhancements

• Remove unused table inline_accounting

Delete branch after merge

NO

Checklist

• Document the feature
• Add unit tests
• Add acceptance tests (TestLink)

[extrafu]

@jrouzierinverse rebase and @nqb / @julsemaan review and merge if fine

[nqb]

Missing files

There is some references to inline.accounting inside pf.conf.defaults and documentation.conf

Drop of DB table

I see you dropped inline_accounting table.
Tell me if I'm wrong but it means that we lost "bandwidth history" for nodes.
I'm not able to see if we lost an old history.

[julsemaan]

Other than @nqb's comments, it looks fine to me

[extrafu]

@jrouzierinverse Finish the work on that PR before tackling bugs.

[nqb]

@jrouzierinverse: there is still some references to inline.accounting inside pf.conf.defaults and documentation.conf

[nqb]

@jrouzierinverse, I did the removal for old config settings. Let me know if it's ok.

I just need an answer on "Drop of DB table" topic I mentioned and we should be ready to merge.

[nqb]

Bump @jrouzierinverse

[nqb]

Task inline_accounting_maintenance run each minute and mark inactive sessions based on:

• $accounting_session_timeout (default value: 300 seconds)
• one day history

Then task update bandwidth_balance column value in node table.

There is also some logical related to management of security event.

I didn't see any jobs that cleanup inline_accounting table so it means all data will be lost. It should impact only users that extract data from this table for external usage. I will merge this PR as-is and add a note in Upgrade guide.