Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFPKI intune support #6360

Merged
merged 38 commits into from
Jul 6, 2021
Merged

PFPKI intune support #6360

merged 38 commits into from
Jul 6, 2021

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented May 14, 2021

Description

Intune scep support.

Impacts

pfpki

Delete branch after merge

YES

Checklist

  • Document the feature
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

New Features

  • Microsoft Intune SCEP support

Comment on lines 13 to 29
<!--
<form-group-tenant-id namespace="tenant_id"
:column-label="$i18n.t('The tenant ID of the Azure service')"
:text="$i18n.t('Define the tenant ID defined in the Azure admin portal.')"
/>

<form-group-client-id namespace="client_id"
:column-label="$i18n.t('The client ID of the Azure service')"
:text="$i18n.t('Define the client ID defined in the Azure admin portal.')"
/>

<form-group-client-secret namespace="client_secret"
:column-label="$i18n.t('The client secret of the Azure service')"
:text="$i18n.t('Define the client secret defined in the Azure admin portal.')"
/>

-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Comment on lines 14 to 16
<!-- <b-dropdown-item :to="{ name: 'newCloud', params: { cloudType: 'Azure' } }">Microsoft Azure</b-dropdown-item>
<b-dropdown-item :to="{ name: 'newCloud', params: { cloudType: 'Google' } }">Google Cloud</b-dropdown-item>
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Comment on lines 13 to 28
<!--
<form-group-tenant-id namespace="tenant_id"
:column-label="$i18n.t('The tenant ID of the Google service')"
:text="$i18n.t('Define the tenant ID defined in the Azure admin portal.')"
/>

<form-group-client-id namespace="client_id"
:column-label="$i18n.t('The client ID of the Google service')"
:text="$i18n.t('Define the client ID defined in the Azure admin portal.')"
/>

<form-group-client-secret namespace="client_secret"
:column-label="$i18n.t('The client secret of the Google service')"
:text="$i18n.t('Define the client secret defined in the Azure admin portal.')"
/>
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove


// @vue/component
export default {
name: 'form-type-intune',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form-type-google


// @vue/component
export default {
name: 'form-type-intune',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form-type-azure

@satkunas
Copy link
Contributor

@fdurand looks good. Fix the minor issue comments above.

I will need to rework changes with #6397., which will cause breaking changes to this VueJS source. Please let me know once this merged.

@fdurand
Copy link
Member Author

fdurand commented Jun 30, 2021

BUMP

@fdurand
Copy link
Member Author

fdurand commented Jul 5, 2021

@jrouzierinverse ready to merge ?

@@ -1500,6 +1500,8 @@ CREATE TABLE `pki_profiles` (
`scep_enabled` int(11) DEFAULT NULL,
`scep_challenge_password` varchar(255) DEFAULT NULL,
`scep_days_before_renewal` varchar(255) DEFAULT NULL,
`cloud_enabled` int(11) DEFAULT NULL,
`cloud_service` varchar(255) DEFAULT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove from here and add it to here db/pf-schema-X.Y.sql.

@fdurand
Copy link
Member Author

fdurand commented Jul 5, 2021

Change done

db/upgrade-10.0.0-10.1.0.sql Outdated Show resolved Hide resolved
debian/packetfence.conffiles Show resolved Hide resolved
@jrouzierinverse jrouzierinverse merged commit 55175f8 into devel Jul 6, 2021
fdurand added a commit that referenced this pull request Jul 6, 2021
nqb added a commit that referenced this pull request Jul 7, 2021
satkunas pushed a commit that referenced this pull request Jul 7, 2021
satkunas pushed a commit that referenced this pull request Jul 7, 2021
@fdurand fdurand deleted the feature/intune branch July 16, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants