Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor maintenance #6378

Merged
merged 45 commits into from
Jun 29, 2021
Merged

Feature/refactor maintenance #6378

merged 45 commits into from
Jun 29, 2021

Conversation

nqb
Copy link
Contributor

@nqb nqb commented May 28, 2021

Description

  • Build packages using Makefile (in place of commands in .gitlab-ci.yml)
  • Extract release version from conf/pf-release to use it during several stages (build_docker_img, test, upload, build_pf_img)
  • Use all runners for upload stage
  • Upload packages directly to web.inverse.ca (no more pfbuilder)
  • Use a RPM and Debian repository per-version (see Create a repo per version #6162)
  • New pristine Debian 9 pristine box (to test from scratch, see tests during a release pipeline should be done against pristine VM #6292)
  • Add a script to simplify release process (specially for patch release)
  • New names for SQL schema upgrade scripts (X.Y.Z => X.Y)
  • Always install packetfence packages from local repository in pipeline
  • Build sources using during RPM packaging with tar in place of git archive to include untracked file (like git_commit_id)

Additional (related to RHEL8 and Debian 11):

  • Add Vagrant boxes for each distribution

Deprecations:

  • pf-maint.pl
  • packetfence-devel and debian-devel repositories

Notes:

  • Documentation will be updated on PR related to RHEL8 and Debian 11.
  • Build of Docker images is not touched because we will start to use new Docker images for RHEL8 and Debian 11

Dependencies

Impacts

  • Package builds for stable, devel and branches environment
  • Maintenance patches

Delete branch after merge

YES

Checklist

  • (WIP) Document the feature
  • Post-merge actions

NEWS file entries

Enhancements

  • Get maintenance patches through package manager

@nqb nqb force-pushed the feature/refactor-maintenance branch 2 times, most recently from 595f669 to 2fc64a4 Compare June 1, 2021 09:11
@nqb nqb force-pushed the feature/refactor-maintenance branch from cea557b to d65600c Compare June 3, 2021 14:46
@nqb nqb force-pushed the feature/refactor-maintenance branch 3 times, most recently from ce8d592 to 243d723 Compare June 11, 2021 14:17
@nqb nqb force-pushed the feature/refactor-maintenance branch 5 times, most recently from cfc6f06 to 806de56 Compare June 22, 2021 11:33
@nqb nqb requested a review from JeGoi June 22, 2021 12:53
@nqb nqb added this to the PacketFence-11.0 milestone Jun 22, 2021
@nqb nqb force-pushed the feature/refactor-maintenance branch from 51fafac to e1f0efb Compare June 23, 2021 19:04
Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions but it looks good.
Nice job

addons/vagrant/requirements.yml Outdated Show resolved Hide resolved
addons/vagrant/requirements.yml Outdated Show resolved Hide resolved
ci/lib/release/prep-release.sh Show resolved Hide resolved
ci/lib/test/Makefile Show resolved Hide resolved
ci/lib/upload/deploy-artifacts.sh Show resolved Hide resolved
ci/packer/zen/Makefile Show resolved Hide resolved
nqb and others added 2 commits June 28, 2021 07:39
Co-authored-by: Jeremy Goimard <13801368+JeGoi@users.noreply.github.com>
Co-authored-by: Jeremy Goimard <13801368+JeGoi@users.noreply.github.com>
@nqb
Copy link
Contributor Author

nqb commented Jun 28, 2021

Commit e1f0efb will break builds. I'm working on fix before we merge.

It allow us to add any file which are not tracked in source (like git_commit_id).
Using config.mk, we limit which top level directories are included in tar archive.
Using dist_ignore file, we can exclude specific files (like .git files)

conf/.gitignore is removed because this file is overriden by conf/.gitignore.example during packaging.

rpm/source and sub-directories are not necessary anymore
@nqb nqb merged commit 6b939b3 into devel Jun 29, 2021
@nqb nqb mentioned this pull request Jun 29, 2021
@nqb nqb deleted the feature/refactor-maintenance branch June 29, 2021 14:04
nqb added a commit that referenced this pull request Jun 29, 2021
nqb added a commit that referenced this pull request Jun 30, 2021
nqb added a commit that referenced this pull request Jun 30, 2021
Related to #6378
Upgrading database schema between two devel packages (11.0 to 11.0) will still failed.
In order to perform such upgrade, we can edit manually db/upgrade-X.X-X.Y.sql to set PREV as current devel minor version.
nqb added a commit that referenced this pull request Sep 9, 2021
nqb added a commit that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants