-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor maintenance #6378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
595f669
to
2fc64a4
Compare
cea557b
to
d65600c
Compare
ce8d592
to
243d723
Compare
cfc6f06
to
806de56
Compare
insert current pf_release in packetfence-release package using macros
packetfence-local ppa don't need to use PF_RELEASE add changelog entry to packetfence-release packages
create target dir debian with conf directory
- conf dir need to be created for Debian - fix path to upload queue - fix issues with wrong path to repositories
pass pf_minor_release to packer build and Ansible provisioner
workaround for https://gitlab.com/gitlab-org/gitlab/-/issues/219437 "When you use rules:, allow_failure defaults to false, including for manual jobs." To keep existing behavior, we need to enforce allow_failure: true idem
deprecate packetfence-devel repo
51fafac
to
e1f0efb
Compare
JeGoi
reviewed
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions but it looks good.
Nice job
Co-authored-by: Jeremy Goimard <13801368+JeGoi@users.noreply.github.com>
Co-authored-by: Jeremy Goimard <13801368+JeGoi@users.noreply.github.com>
Commit e1f0efb will break builds. I'm working on fix before we merge. |
It allow us to add any file which are not tracked in source (like git_commit_id). Using config.mk, we limit which top level directories are included in tar archive. Using dist_ignore file, we can exclude specific files (like .git files) conf/.gitignore is removed because this file is overriden by conf/.gitignore.example during packaging. rpm/source and sub-directories are not necessary anymore
nqb
added a commit
that referenced
this pull request
Jun 30, 2021
Related to #6378 Upgrading database schema between two devel packages (11.0 to 11.0) will still failed. In order to perform such upgrade, we can edit manually db/upgrade-X.X-X.Y.sql to set PREV as current devel minor version.
nqb
added a commit
that referenced
this pull request
Sep 9, 2021
nqb
added a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.gitlab-ci.yml
)conf/pf-release
to use it during several stages (build_docker_img, test, upload, build_pf_img)tar
in place ofgit archive
to include untracked file (likegit_commit_id
)Additional (related to RHEL8 and Debian 11):
Deprecations:
pf-maint.pl
packetfence-devel
anddebian-devel
repositoriesNotes:
Dependencies
Impacts
Delete branch after merge
YES
Checklist
NEWS file entries
Enhancements