Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the deprecated NTLM background job fields and components #6599

Merged
merged 5 commits into from
Oct 4, 2021

Conversation

julsemaan
Copy link
Collaborator

Description

Removes the deprecated NTLM background job fields and components

Impacts

NTLM cache

Issue

fixes #6552

Delete branch after merge

YES

@julsemaan
Copy link
Collaborator Author

I tested the NTLM cache on this branch and it works correctly like in 11.0 (cache on connection only)

@nqb
Copy link
Contributor

nqb commented Sep 28, 2021

@julsemaan, you said on #6552 (comment) that some fields need to be removed from ./_components/index.js, is it still necessary ?

@julsemaan
Copy link
Collaborator Author

Looks like @satkunas did already remove them when I checked

@nqb
Copy link
Contributor

nqb commented Oct 4, 2021

Tested, work as expected.

@nqb nqb merged commit 8d3855b into devel Oct 4, 2021
nqb added a commit that referenced this pull request Oct 4, 2021
satkunas pushed a commit that referenced this pull request Oct 4, 2021
nqb added a commit that referenced this pull request Oct 5, 2021
@satkunas satkunas deleted the feature/cleanup-ntlm-background branch May 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate backend code related to NTLM cache background job
2 participants